Re: [Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

[Wanlong Gao]

On 08/22/2013 04:59 AM, Eric Blake wrote:
> On 08/19/2013 07:07 PM, Wanlong Gao wrote:
>> Reviewed-by: Laszlo Ersek <address@hidden>
>> Signed-off-by: Wanlong Gao <address@hidden>
>> ---
>>  qapi-schema.json | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 47 insertions(+)
>>
> 
>> +##
>> +# @NumaNodeOptions
>> +#
>> +# Create a guest NUMA node.
>> +#
>> +# @nodeid: #optional NUMA node ID
>> +#
>> +# @cpus: #optional VCPUs belong to this node
>> +#
>> +# @mem: #optional memory size of this node (remain as legacy)
> 
> What does (remain as legacy) mean, that I shouldn't use this parameter?
> Is it something where the command line parsing code should be
> translating the legacy option into the correct usage of the QMP command,
> so we don't have to expose cruft?

OK, will remove this.

> 
>> +#
>> +# Since: 1.7
>> +##
>> +{ 'type': 'NumaNodeOptions',
>> +  'data': {
>> +   '*nodeid': 'uint16',
>> +   '*cpus':   ['uint16'],
>> +   '*mem':    'str' }}
> 
> Why is size passed as a 'str' instead of an integral type?  If anything,
> at the QMP layer, it should be an integer representing size in bytes
> (the command line and HMP are already capable of converting shorthand
> like 1G into proper byte counts for use in QAPI).

Since the original "mem" options is MB default, but "size" type is byte default,
so we should pass a "str" first to be consistent with original option.

> 
>> +
>> +##
>> +# @NumaMemOptions
>> +#
>> +# Set memory information of guest NUMA node.
>> +#
>> +# @nodeid: #optional NUMA node ID
>> +#
>> +# @size: #optional memory size of this node
> 
> If everything is optional, then what defaults are used if I specify
> nothing?  Should nodeid be mandatory (here, and in NumaNodeOptions)?

The defaults are all consistent with original behaviour. If nodeid is
omitted, the option will be assigned node by node from node0.

Thanks,
Wanlong Gao


>