Re: [Qemu-devel] [PATCH v3 0/3] slirp: fill mainloop with more precise timeout value

[Stefan Hajnoczi]

On Wed, Aug 21, 2013 at 10:15:49AM +0800, Liu Ping Fan wrote:
> With this series, we can set the mainloop timeout more precisely when slirp 
> has
> to emulate tcp timeout problem.
> 
> v3:
>   fix comment: document timeout unit "milliseconds"
>   fix logic: no slirps, no timeout modifications in slirp_pollfds_fill()
> v2:
>   fold slirp_update_timeout logic into slirp_pollfds_fill.
> 
> 
> Liu Ping Fan (3):
>   slirp: make timeout local
>   slirp: define timeout as macro
>   slirp: set mainloop timeout with more precise value
> 
>  main-loop.c      |  3 +--
>  slirp/libslirp.h |  3 +--
>  slirp/slirp.c    | 55 +++++++++++++++++++++++++++++++++++++++----------------
>  slirp/slirp.h    |  3 +++
>  stubs/slirp.c    |  6 +-----
>  5 files changed, 45 insertions(+), 25 deletions(-)

These patches look okay, I've skimmed them.  Leaving detailed slirp review to 
Jan.

Stefan