Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

[Markus Armbruster]

Andreas Färber <address@hidden> writes:

> Am 22.08.2013 14:48, schrieb Marcel Apfelbaum:
>> This patch follows Markus Armbruster suggestion:
>> 
>> A possibly better way to group help by category: instead of adding
>> categories to each line, add category headlines, like this:
>> 
>>     Controller/Bridge/Hub devices:
>>     name "NAME", bus "BUS"...
>>     ...
>>     USB devices:
>>     name "NAME", bus "BUS"...
>>     ...
>>     Storage devices:
>>     ...
>> 
>> This way, showing devices with multiple categories once per category
>> actually makes sense.
>> 
>> Note that the "categories to each line" is kept for 2 reasons:
>> 1. Preparation for multifunction devices
>> 2. Ability to grep by category
>> 
>> Signed-off-by: Marcel Apfelbaum <address@hidden>
>> ---
>>  qdev-monitor.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/qdev-monitor.c b/qdev-monitor.c
>> index 410cdcb..a7329b0 100644
>> --- a/qdev-monitor.c
>> +++ b/qdev-monitor.c
>> @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory 
>> category)
>>      DeviceClass *dc;
>>      GSList *list, *curr;
>>  
>> +    error_printf("%s devices:\n", qdev_category_get_name(category));
>
> Why is that an error? Shouldn't it go to stdout?

Output of -device help has always gone to stderr, and that has always
annoyed me.  Just not enough to fix it.

[...]