Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1

[Ján Tomko]

On 08/19/2013 11:25 AM, Kevin Wolf wrote:
> By the time that qemu 1.7 will be released, enough time will has passed
> since qemu 1.1, which is the first version to understand version 3
> images, that changing the default shouldn't hurt many people any more
> and the benefits of using the new format outweigh the pain.
> 
> qemu-iotests already runs with compat=1.1 by default.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 3376901..42ea7ec 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1402,7 +1402,7 @@ static int qcow2_create(const char *filename, 
> QEMUOptionParameter *options)
>      int flags = 0;
>      size_t cluster_size = DEFAULT_CLUSTER_SIZE;
>      int prealloc = 0;
> -    int version = 2;
> +    int version = 3;
>  
>      /* Read out options */
>      while (options && options->name) {
>

This does not affect qemu-img (or bdrv_img_create), as it gets overwritten
with 2 when BLOCK_OPT_COMPAT_LEVEL is present in options, but the value is NULL.

Should this go into qcow2_create_options[] as well?

Jan