qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] prep: improve Raven PCI host emulation


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH 3/3] prep: improve Raven PCI host emulation
Date: Fri, 23 Aug 2013 12:56:15 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 08/23/2013 11:52 AM, Hervé Poussineau wrote:
> +    uint8_t buf[4];
> +    uint64_t val;
> +
> +    if (s->contiguous_map == 0) {
> +        /* 64 KB contiguous space for IOs */
> +        addr &= 0xFFFF;
> +    } else {
> +        /* 8 MB non-contiguous space for IOs */
> +        addr = (addr & 0x1F) | ((addr & 0x007FFF000) >> 7);
> +    }
> +
> +    address_space_read(&s->pci_io_as, addr + 0x80000000, buf, size);
> +    memcpy(&val, buf, size);
> +    return val;

This memcpy can't be right, especially for big-endian host.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]