qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [qemu-devel] [PATCH v2] target-i386: Fix segment cache


From: Peter Maydell
Subject: Re: [Qemu-devel] [qemu-devel] [PATCH v2] target-i386: Fix segment cache dump
Date: Sat, 24 Aug 2013 11:40:53 +0100

On 23 August 2013 20:09, Tobias Markus <address@hidden> wrote:
> When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default 
> operation size bit (D/B bit) is not set for Long Mode Data Segments since 
> there are only Data Segments in Long Mode and no explicit 16/32/64-bit 
> Descriptors.
> This patch fixes this by checking the Long Mode Active bit of the hidden 
> flags variable and logging "DS" if it is set. (I.e. in Long Mode all Data 
> Segments are logged as "DS")

If you need to do another version of this patch, it would be nice
to (manually) wrap the commit message and your below-the-"---"
comments at about column 75. Otherwise whoever commits
the patch could maybe fix up the message.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]