Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

[Alexander Graf]

On 26.08.2013, at 11:08, Nikunj A Dadhania wrote:

> Alexander Graf <address@hidden> writes:
> 
>> Am 26.08.2013 um 08:22 schrieb Benjamin Herrenschmidt <address@hidden>:
>> 
>>> On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote:
>>>>> +    cap.flags = 0;
>>>>> +    cap.migration.ecl = 0;
>>>>> +    cap.reserve.type = 0;
>>>>> +    cap.migration.common.server_support = 0;
>>>>> +    cap.reserve.common.server_support = 0;
>>>> 
>>>> My question stands unanswered. Is this just memset(0)?
>>> 
>>> If it is, then why bother reading it in the first place ? :-)
>> 
>> Because this is a revision that incorporates other feedback from that same 
>> review, so I'm quite sure he just missed it :)
> 
> Nope, i did not miss it.

So you ignored it on purpose?


Alex