Re: [Qemu-devel] [PATCH 24/47] hw/display/Kconfig: Add Kconfig file

[Paolo Bonzini]

Il 26/08/2013 00:58, Ákos Kovács ha scritto:
> Signed-off-by: Ákos Kovács <address@hidden>
> ---
>  hw/display/Kconfig |   84 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 hw/display/Kconfig
> 
> diff --git a/hw/display/Kconfig b/hw/display/Kconfig
> new file mode 100644
> index 0000000..1f6f386
> --- /dev/null
> +++ b/hw/display/Kconfig
> @@ -0,0 +1,84 @@
> +config ADS7846
> +    bool
> +    select SSI

Similarly this should be "depends on".  To put it more clearly:

- devices that are on a particular bus should "depend on" that bus;

- devices that expose a particular bus (for example a PCI host bridge)
should "select" it so that the user can choose which devices to enable
on that board

- devices can also "select" library features that they use, for example
FRAMEBUFFER or PTIMER, or "sub-devices" that they include, for example
VGA or what you did in I82378

- boards should also "select" devices, but you got that part right so no
need to explain :)

Paolo

> +config VGA_CIRRUS
> +    bool
> +    depends on PCI
> +    select VGA
> +    #select ISA
> +
> +config G364FB
> +    bool
> +
> +config JAZZ_LED
> +    bool
> +
> +config PL110
> +    bool
> +    select FRAMEBUFFER
> +
> +config SSD0303
> +    bool
> +    #select I2C
> +
> +config SSD0323
> +    bool
> +    select SSI
> +
> +config VGA_PCI
> +    bool
> +    select VGA
> +    depends on PCI
> +
> +config VGA_ISA
> +    bool
> +    select VGA
> +    #select ISA
> +
> +config VGA_ISA_MM
> +    bool
> +    select VGA
> +
> +config VMWARE_VGA
> +    bool
> +    select VGA
> +    depends on PCI
> +
> +config BLIZZARD
> +    bool
> +
> +config FRAMEBUFFER
> +    bool
> +
> +config MILKYMIST
> +    bool
> +    select FRAMEBUFFER
> +
> +config ZAURUS
> +    bool
> +    select NAND
> +    select ECC
> +
> +config OMAP
> +    bool
> +    select FRAMEBUFFER
> +
> +config PXA2XX
> +    bool
> +    select FRAMEBUFFER
> +
> +config MILKYMIST_TMU2
> +    bool
> +
> +config SM501
> +    bool
> +
> +config TCX
> +    bool
> +
> +config VGA
> +    bool
> +
> +config QXL
> +    bool
>