[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] curl: qemu_bh_new() can never return NULL
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] curl: qemu_bh_new() can never return NULL |
Date: |
Mon, 26 Aug 2013 15:48:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 26/08/2013 13:38, Stefan Hajnoczi ha scritto:
> Drop error code path which cannot be taken since qemu_bh_new() does not
> return NULL.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/curl.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index e566855..ca2cedc 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -572,12 +572,6 @@ static BlockDriverAIOCB *curl_aio_readv(BlockDriverState
> *bs,
> acb->nb_sectors = nb_sectors;
>
> acb->bh = qemu_bh_new(curl_readv_bh_cb, acb);
> -
> - if (!acb->bh) {
> - DPRINTF("CURL: qemu_bh_new failed\n");
> - return NULL;
> - }
> -
> qemu_bh_schedule(acb->bh);
> return &acb->common;
> }
>
Reviewed-by: Paolo Bonzini <address@hidden>