Re: [Qemu-devel] [PATCH] monitor: Add missing attributes to local function

[Luiz Capitulino]

On Thu, 22 Aug 2013 21:30:09 +0200
Stefan Weil <address@hidden> wrote:

> Function expr_error gets a format string and variable arguments like printf.
> It also never returns. Add the necessary attributes.
> 
> Signed-off-by: Stefan Weil <address@hidden>

Applied to the qmp branch, thanks.

> ---
>  monitor.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/monitor.c b/monitor.c
> index da9c9a2..6413d44 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3171,7 +3171,8 @@ static const MonitorDef monitor_defs[] = {
>      { NULL },
>  };
>  
> -static void expr_error(Monitor *mon, const char *fmt, ...)
> +static void GCC_FMT_ATTR(2, 3) QEMU_NORETURN
> +expr_error(Monitor *mon, const char *fmt, ...)
>  {
>      va_list ap;
>      va_start(ap, fmt);