qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V18 06/25] add interface to block


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH V18 06/25] add interface to block
Date: Tue, 27 Aug 2013 16:08:36 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben:
> Subject: Re: [PATCH V18 06/25] add interface to block

This is _not_ a good subject line.

> To make patches easy for reviewing, each block format is
> a single patch. Add a new interface to block layer to make
> sure origin code can compile and do not change any code
> logic.
> 
> Signed-off-by: Dong Xu Wang <address@hidden>

I believe that adding a second copy of each creation function actually
makes reviewing harder than just changing the option parsing part in it.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]