qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V18 02/25] qemu-option: avoid duplication of def


From: Dong Xu Wang
Subject: Re: [Qemu-devel] [PATCH V18 02/25] qemu-option: avoid duplication of default value in QemuOpts
Date: Thu, 29 Aug 2013 09:49:28 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8

On 2013/8/28 20:57, Eric Blake wrote:
On 08/12/2013 10:31 PM, Dong Xu Wang wrote:
This patch moves the default value entirely to QemuOptDesc.

When getting the value of an option that hasn't been set, and
QemuOptDesc has a default value, return that.  Else, behave as
before.

...
    Else, return NULL.

Signed-off-by: Dong Xu Wang <address@hidden>
Reviewed-by: Eric Blake <address@hidden>

v13->v14:
1) change code style.
2) assert errors.

Signed-off-by: Dong Xu Wang <address@hidden>

Conflicts:
        util/qemu-option.c
---

Awkward.  You should never have a 'Conflicts:' section on an upstream
patch (except for maintainers resolving trivial conflicts during a merge
operation); and this is another case of needing to move your submission
changelog after the ---.

Okay, thank you, Eric.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]