Re: [Qemu-devel] [PATCH] PPC: KVM: Compile fix for qemu_notify_event

[Andreas Färber]

Am 29.08.2013 02:13, schrieb Alexander Graf:
> The function qemu_notify_event is defined by a header that we don't
> include in the PPC KVM code. Include it to get the code building
> again.
> 
>   target-ppc/kvm_ppc.c: In function 'kvmppc_timer_hack':
>   target-ppc/kvm_ppc.c:26:5: error: implicit declaration of function 
> 'qemu_notify_event' [-Werror=implicit-function-declaration]
>   target-ppc/kvm_ppc.c:26:5: error: nested extern declaration of 
> 'qemu_notify_event' [-Werror=nested-externs]
> 
> Signed-off-by: Alexander Graf <address@hidden>
> ---
>  target-ppc/kvm_ppc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target-ppc/kvm_ppc.c b/target-ppc/kvm_ppc.c
> index 9b83655..f769acd 100644
> --- a/target-ppc/kvm_ppc.c
> +++ b/target-ppc/kvm_ppc.c
> @@ -15,6 +15,7 @@
>  #include "qemu/timer.h"
>  #include "kvm_ppc.h"
>  #include "sysemu/device_tree.h"
> +#include "qemu/main-loop.h"
>  
>  #define PROC_DEVTREE_PATH "/proc/device-tree"
>  

Matches my local fix, so

Tested-by: Andreas Färber <address@hidden>

but I didn't find out yet who/what broke this, since the
qemu_notify_event() line hasn't changed in a long time according to
git-blame...

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg