qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v2 08/15] Convert bdrv_create and associated funct


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC v2 08/15] Convert bdrv_create and associated functions to be coroutine_fn
Date: Thu, 29 Aug 2013 17:31:35 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Aug 09, 2013 at 07:43:58PM +0200, Charlie Shepherd wrote:
> This patch converts bdrv_create, bdrv_create_file and bdrv_img_create to be
> coroutine only functions. It adds a synchronous wrapper, bdrv_sync_create, for
> any synchronous callers.

It would be more consistent to call the coroutine_fn bdrv_co_create()
and the synchronous function bdrv_create().  We don't have the
bdrv_sync_foo() naming convention and it's easily confused with the
bdrv_pwrite_sync() function which flushes the disk cache (fsync(2)).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]