Re: [Qemu-devel] [PATCH 17/18] tcg-i386: Adjust tcg_out_tlb_load for x32

[Richard Henderson]

On 08/29/2013 09:45 AM, Aurelien Jarno wrote:
>> > -    tcg_out_mov(s, type, r1, addrlo);
>> > +    tcg_out_mov(s, ttype, r1, addrlo);
> This one is not fully correct. It should be ttype for the slow path (the
> value is used as an argument to the helper function), but htype for the
> fast path (the value is used as a host pointer).
> 
> Using ttype currently ensures the type is safe, but it might worth
> adding a comment in case ttype or htype is changed.

You're right, I'm not zero-extending the register properly for the fast path,
in the case of a 64-bit guest.

Although I could save more space on the fast path for x32 by avoiding the
copy/zero-extension here and instead using the ADDR32 prefix on the actual
memory operation.

Will fix.


r~