Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line.

[Benoît Canet]

> > @@ -1404,10 +1404,16 @@ Arguments:
> >  - "device": device name (json-string)
> >  - "bps":  total throughput limit in bytes per second(json-int)
> >  - "bps_rd":  read throughput limit in bytes per second(json-int)
> > -- "bps_wr":  read throughput limit in bytes per second(json-int)
> > +- "bps_wr":  write throughput limit in bytes per second (json-int)

I though that fixing coding style related issues in lines non directly impacted 
by a
patch was bad so I changed only this one. The funny thing is that it propagate
the scope of the patch.

> It's odd that you are fixing one pre-existing case of missing space, but
> not all of them.  Should we split the cleanups into a separate patch?  I
> already started some cleanups[1], but could respin my patch to cover
> more, if desired.
> 
> > @@ -1417,7 +1423,13 @@ Example:
> >                                                 "bps_wr": "0",
> >                                                 "iops": "0",
> >                                                 "iops_rd": "0",
> > -                                               "iops_wr": "0" } }
> > +                                               "iops_wr": "0",
> 
> Depending on whether my patch[1] goes in first, fix this to use '0'
> instead of '"0"'.
> 
> [1] still waiting for it to hit
> https://lists.gnu.org/archive/html/qemu-devel/2013-08/threads.html, but
> message id <address@hidden> [PATCH]
> qmp: fix integer usage in examples
I rebased on top of it.

Best regards

Benoît