Re: [Qemu-devel] [PATCH v4 5/5] qemu-iotest: qcow2 image option amendment

[Kevin Wolf]

Am 02.09.2013 um 12:04 hat Max Reitz geschrieben:
> Add tests for qemu-img amend on qcow2 image files.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  tests/qemu-iotests/061     | 178 +++++++++++++++++++++++
>  tests/qemu-iotests/061.out | 349 
> +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 528 insertions(+)
>  create mode 100755 tests/qemu-iotests/061
>  create mode 100644 tests/qemu-iotests/061.out

It might be worth adding test cases for...

* Leaving an encrypted image encrypted, implicitly or explicitly
* Zero cluster expansion with an (active/inactive) L2 table with
  refcount > 1
* State after a failed amend operation (or do we even promise anything?
  I guess if you pass multiple options, some may be applied and some not)

What's there looks good (except for the one bug I mentioned)

Kevin