[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] w32: Fix access to host devices (regression)
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] w32: Fix access to host devices (regression) |
|
Date: |
Tue, 03 Sep 2013 11:55:17 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
Am 03.09.2013 10:51, schrieb Kevin Wolf:
> Am 01.09.2013 um 22:59 hat Stefan Weil geschrieben:
>> QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard disk)
>> since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?).
>>
>> Those devices use hdev_open which did not use the latest API for options.
>> This resulted in a fatal runtime error:
>>
>> Block protocol 'host_device' doesn't support the option 'filename'
>>
>> Duplicate code from raw_open to fix this.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>
> Reviewed-by: Kevin Wolf <address@hidden>
>
>> ---
>>
>> This bug was reported by David Brenner.
>> It should be fixed in QEMU 1.6 as well.
>
> Cc: address@hidden
>
> (Ideally you'd also put this Cc line in your commit message.)
...and put the attribution as:
Reported-by: David Brenner <address@hidden>
Maybe Stefan H. can still add that along with the Cc.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg