[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] dump-guest-memory: Check for the correct return val
From: |
Aneesh Kumar K.V |
Subject: |
[Qemu-devel] [PATCH] dump-guest-memory: Check for the correct return value |
Date: |
Wed, 4 Sep 2013 16:10:39 +0530 |
From: "Aneesh Kumar K.V" <address@hidden>
We should check for error with s->note_size
Signed-off-by: Aneesh Kumar K.V <address@hidden>
---
dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dump.c b/dump.c
index c0dae2c..80dd9d6 100644
--- a/dump.c
+++ b/dump.c
@@ -66,7 +66,7 @@ typedef struct DumpState {
uint32_t sh_info;
bool have_section;
bool resume;
- size_t note_size;
+ ssize_t note_size;
hwaddr memory_offset;
int fd;
@@ -765,7 +765,7 @@ static int dump_init(DumpState *s, int fd, bool paging,
bool has_filter,
s->note_size = cpu_get_note_size(s->dump_info.d_class,
s->dump_info.d_machine, nr_cpus);
- if (ret < 0) {
+ if (s->note_size < 0) {
error_set(errp, QERR_UNSUPPORTED);
goto cleanup;
}
--
1.8.1.2
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] dump-guest-memory: Check for the correct return value,
Aneesh Kumar K.V <=