Re: [Qemu-devel] [RFC 1/3] bdrv: Use "Error" for opening images

[Kevin Wolf]

Am 05.09.2013 um 10:10 hat Max Reitz geschrieben:
> Add an Error ** parameter to bdrv_open, bdrv_file_open and bdrv_create
> to allow more specific error messages.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block.c                   |  6 +++---
>  block/blkdebug.c          |  3 ++-
>  block/blkverify.c         |  3 ++-
>  block/bochs.c             |  3 ++-
>  block/cloop.c             |  3 ++-
>  block/cow.c               |  6 ++++--
>  block/dmg.c               |  3 ++-
>  block/nbd.c               |  3 ++-
>  block/parallels.c         |  3 ++-
>  block/qcow.c              |  6 ++++--
>  block/qcow2.c             |  8 +++++---
>  block/qed.c               |  8 +++++---
>  block/raw-posix.c         | 18 ++++++++++++------
>  block/raw_bsd.c           |  6 ++++--
>  block/sheepdog.c          |  6 ++++--
>  block/snapshot.c          |  2 +-
>  block/vdi.c               |  6 ++++--
>  block/vhdx.c              |  3 ++-
>  block/vmdk.c              |  6 ++++--
>  block/vpc.c               |  6 ++++--
>  block/vvfat.c             |  3 ++-
>  include/block/block_int.h |  9 ++++++---
>  22 files changed, 78 insertions(+), 42 deletions(-)

Don't rely on compiler errors for changing the prototypes: There are
more block drivers which just aren't compiled on your system, either
because they are for a different platform (like raw-win32.c) or they
require headers that you don't have installed, so configure disabled
them.

Kevin