Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

[Alexander Graf]

On 05.09.2013, at 15:05, Andreas Färber wrote:

> Am 05.09.2013 14:54, schrieb Alexander Graf:
>> 
>> On 01.08.2013, at 16:12, Jason J. Herne wrote:
>> 
>>> From: "Jason J. Herne" <address@hidden>
>>> 
>>> Latest code for cpu Hotplug on S390 architecture.   This one is vastly 
>>> simpler
>>> than v2 as we have decided to avoid the command line specification 
>>> of -device s390-cpu.
>>> 
>>> The last version can be found here:
>>> http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg01183.html
>>> 
>>> There is also a patch in this series to add cpu-add to the Qemu monitor
>>> interface.
>>> 
>>> Hotplugged cpus are created in the configured state and can be used by the
>>> guest after the guest onlines the cpu by: 
>>> "echo 1 > /sys/bus/cpu/devices/cpuN/online"
>>> 
>>> Hot unplugging is currently not implemented by this code. 
>> 
>> Very simple and clean patch set. I don't think it deserves the RFC tag.
> 
> Negative, see my review. If you want to fix up and queue patches 1-2
> that's fine with me, but the others need a respin. No major blocker
> though, just some more footwork mostly related to QOM and Jason's
> shifted focus on cpu-add rather than device_add.

Yeah, that's what I'm referring to. I've seen a lot worse patch sets at v8 than 
this RFC :).

I don't think we should apply it as is, and I'm very happy to see your review 
and comment on the modeling bits :). But I try to never apply or cherry pick 
RFC patches - and this set looks like he sent it with the intent of getting it 
merged.


Alex