[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] target-arm: Avoid clang sanitizer warnin
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] target-arm: Avoid clang sanitizer warnings |
Date: |
Thu, 05 Sep 2013 08:28:12 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/05/2013 07:38 AM, Peter Maydell wrote:
> These patches avoid some clang sanitizer warnings triggered
> on target-arm code which inadvertently shifts into the sign
> bit of a signed integer (which is undefined behaviour in C).
>
> Changes v1->v2:
> * made all the CPSR_* defines unsigned for consistency
> (suggested by rth in review)
>
> Peter Maydell (2):
> target-arm: Use sextract32() in branch decode
> target-arm: Avoid "1 << 31" undefined behaviour
>
> target-arm/cpu.h | 32 ++++++++++++++++----------------
> target-arm/helper.c | 4 ++--
> target-arm/translate.c | 5 +++--
> 3 files changed, 21 insertions(+), 20 deletions(-)
>
Reviewed-by: Richard Henderson <address@hidden>
r~