Re: [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime

[Bandan Das]

Gerd Hoffmann <address@hidden> writes:

>> --- a/hw/audio/hda-codec.c
>> +++ b/hw/audio/hda-codec.c
>> @@ -118,7 +118,20 @@ static void hda_codec_parse_fmt(uint32_t format, struct 
>> audsettings *as)
>>  #define QEMU_HDA_AMP_NONE    (0)
>>  #define QEMU_HDA_AMP_STEPS   0x4a
>>  
>> +#ifdef CONFIG_MIXEMU
>> +#define   PARAM mixemu
>> +#define   HDA_MIXER
>>  #include "hda-codec-common.h"
>> +#else
>> +/* keep the compiler quiet */
>> +static const desc_codec output_mixemu;
>> +static const desc_codec duplex_mixemu;
>> +static const desc_codec micro_mixemu;
>
> Needed?  The *_mixemu variants are not referenced without CONFIG_MIXEMU

Indeed, they are not needed anymore. Thanks for the catch. I will fix this in a 
follow-up
post.

>> +#endif
>> +
>> +#define   PARAM nomixemu
>
> #undefine HDA_MIXER
>
This is not needed as I already undef this in the header file.

>> +#include  "hda-codec-common.h"
>> +
>
> cheers,
>   Gerd