Re: [Qemu-devel] [PATCH v2 3/3] audio: remove CONFIG_MIXEMU configure option and enable mixemu by default

[Bandan Das]

Gerd Hoffmann <address@hidden> writes:

> On Do, 2013-09-05 at 18:24 -0400, Bandan Das wrote:
>> Set mixer property to on by default.
>
> The "by default" in the commit message is a bit misleading.  There is no
> default any more once CONFIG_MIXEMU is gone ...

I was actually referring to the mixemu property which is 
hda-codec specific; should have worded it better. Anyway, the commit message:
"audio: remove CONFIG_MIXEMU configure option" is descriptive enough I think.

>> Also, always include two versions
>> of devices (with and without mixemu) so that user can select one of 
>> them at runtime.
>
> That applies to hda audio only, and it's patch #2 actually implementing
> that (for the CONFIG_MIXEMU=y case).
>

Yes, you are right. This is hda-codec specific and while patch 2 adds both
versions only when CONFIG_MIXEMU is defined, this change adds both versions
unconditionally. Again, probably evident enough since CONFIG_MIXEMU is being
removed, so I will remove this part from the commit message.

Thanks,
Bandan

> cheers,
>   Gerd