Re: [Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install"

[Fam Zheng]

On Wed, 09/11 15:50, Paolo Bonzini wrote:
> Il 11/09/2013 15:34, Fam Zheng ha scritto:
> > Install all the subdirs for modules under configure option "moddir".
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  Makefile | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index c50b4b3..ca84d32 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -360,6 +360,12 @@ install-datadir install-localstatedir
> >  ifneq ($(TOOLS),)
> >     $(INSTALL_PROG) $(STRIP_OPT) $(TOOLS) "$(DESTDIR)$(bindir)"
> >  endif
> > +ifneq ($(CONFIG_MODULES),)
> 
> Perhaps modules-m instead of CONFIG_MODULES would be more clearer given
> the "for" line immediately below.

modules-m has things even configured without --enable-modules, I think we don't 
install .so here.

> 
> > +   for s in $(patsubst %.mo,%.so,$(modules-m)); do \
> 
> DSOSUF here.

OK.

Fam
> 
> > +           $(INSTALL_DIR) "$(DESTDIR)$(moddir)/$$(dirname $$s)"; \
> > +           $(INSTALL_PROG) $(STRIP_OPT) $$s 
> > "$(DESTDIR)$(moddir)/$$(dirname $$s)"; \
> 
> Paolo
> 
> > +   done
> > +endif
> >  ifneq ($(HELPERS-y),)
> >     $(INSTALL_DIR) "$(DESTDIR)$(libexecdir)"
> >     $(INSTALL_PROG) $(STRIP_OPT) $(HELPERS-y) "$(DESTDIR)$(libexecdir)"
> > 
>