Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules

[Fam Zheng]

On Wed, 09/11 16:41, Daniel P. Berrange wrote:
> On Wed, Sep 11, 2013 at 09:34:08PM +0800, Fam Zheng wrote:
> > The converted block drivers are:
> > 
> >     curl
> >     iscsi
> >     rbd
> >     ssh
> >     glusterfs
> > 
> > no longer adds flags and libs for them to global variables, instead
> > create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is
> > used as per object cflags and libs.
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  block/Makefile.objs | 11 ++++++++++-
> >  configure           | 33 +++++++++++++++------------------
> >  2 files changed, 25 insertions(+), 19 deletions(-)
> 
> After this is applied, I can no longer use http:/// URIs with the
> curl driver, if I do not build with  '--enable-modules' passed to
> configure.
> 
>   $  ~/usr/qemu-git/bin/qemu-system-x86_64 -cdrom 
> http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso
> qemu-system-x86_64: -cdrom 
> http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso:
>  Unknown protocol
> qemu-system-x86_64: -cdrom 
> http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso:
>  could not open disk image 
> http://www.mirrorservice.org/sites/dl.fedoraproject.org/pub/fedora/linux//releases/19/Fedora/x86_64/os/images/boot.iso:
>  No such file or directory
> 
> 
> So it seems driver registration is broken in some way when modules aren't
> enabled at compile time.
> 
Yes, patch 05 is broken (see my reply there). Thanks for pointing out.