Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

[Stefan Hajnoczi]

On Wed, Sep 11, 2013 at 05:38:07PM +0200, Kevin Wolf wrote:
> Am 11.09.2013 um 17:32 hat Gabriel Kerneis geschrieben:
> > On Wed, Sep 11, 2013 at 05:24:55PM +0200, Kevin Wolf wrote:
> > > In config-host.make we do get:
> > > 
> > >     CONFIG_COROUTINE_POOL=0
> > > 
> > > But when config-host.h is generated from it, I assume it's only checked
> > > if the variable is defined, so we end up with:
> > > 
> > >     #define CONFIG_COROUTINE_POOL 1
> > 
> > Did you clean your tree?
> > 
> > $ rm -rf *
> > $ ../../configure --disable-coroutine-pool
> > $ make config-host.h
> > $ grep COROUTINE_POOL config-host.h
> > #define CONFIG_COROUTINE_POOL 0
> 
> My bad, I checked after configure, but before running make. We must have
> a weird build system that this isn't created during configure. :-)

Yes, this confused by too once or twice while writing this patch :).

The relevant code in scripts/create_config is:

 CONFIG_*=*) # configuration
    name=${line%=*}
    value=${line#*=}
    echo "#define $name $value"
    ;;

Stefan