[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/11] scsi: Fix scsi_bus_legacy_add_drive() scsi-gen
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 04/11] scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial |
Date: |
Thu, 12 Sep 2013 13:17:07 +0200 |
From: Markus Armbruster <address@hidden>
scsi_bus_legacy_add_drive() creates either a scsi-disk or a
scsi-generic device. It sets property "serial" to argument serial
unless null. Crashes with scsi-generic, because it doesn't have such
the property.
Only usb_msd_initfn_storage() passes non-null serial. Reproducer:
$ qemu-system-x86_64 -nodefaults -display none -S -usb \
-drive if=none,file=/dev/sg1,id=usb-drv0 \
-device usb-storage,id=usb-msd0,drive=usb-drv0,serial=123
qemu-system-x86_64: -device
usb-storage,id=usb-msd0,drive=usb-drv0,serial=123: Property '.serial' not found
Aborted (core dumped)
Fix by handling exactly like "removable": set the property only when
it exists.
Cc: address@hidden
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/scsi-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index 5cd6137..4d36841 100644
--- a/hw/scsi/scsi-bus.c
+++ b/hw/scsi/scsi-bus.c
@@ -224,7 +224,7 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus,
BlockDriverState *bdrv,
if (object_property_find(OBJECT(dev), "removable", NULL)) {
qdev_prop_set_bit(dev, "removable", removable);
}
- if (serial) {
+ if (serial && object_property_find(OBJECT(dev), "serial", NULL)) {
qdev_prop_set_string(dev, "serial", serial);
}
if (qdev_prop_set_drive(dev, "drive", bdrv) < 0) {
--
1.8.3.1
- [Qemu-devel] [PULL 00/11] SCSI patches for 2013-09-11, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 02/11] spapr-vscsi: add task management, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 04/11] scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial,
Paolo Bonzini <=
- [Qemu-devel] [PULL 05/11] hw/scsi/lsi53c895a: Use sextract32 for sign-extension, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 01/11] scsi: prefer UUID to VM name for the initiator name, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 06/11] hw/scsi/lsi53c895a: Use deposit32 rather than handcoded shift/mask, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 03/11] virtio-scsi: Make type virtio-scsi-common abstract, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 07/11] iscsi: add logical block provisioning information to iscsilun, Paolo Bonzini, 2013/09/12
- [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status, Paolo Bonzini, 2013/09/12