[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op |
Date: |
Thu, 12 Sep 2013 15:35:25 +0100 |
On 12 September 2013 15:31, Claudio Fontana <address@hidden> wrote:
> On 12.09.2013 16:02, Richard Henderson wrote:
>> On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>>> Ok
>>
>> Sadly, "Ok" is neither Reviewed-by or Signed-off-by
> There is nothing sad about it. When it's reviewed, you will know.
The point is that "Ok" is not particularly useful feedback
because it looks like a reviewd-by/acked-by but isn't. It's
confusing so it's better to avoid it.
-- PMM
[Qemu-devel] [PATCH v3 04/29] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 05/29] tcg-aarch64: Change enum aarch64_arith_opc to AArch64Insn, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 02/29] tcg-aarch64: Change all ext variables to bool, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 07/29] tcg-aarch64: Introduce tcg_fmt_* functions, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 06/29] tcg-aarch64: Merge enum aarch64_srr_opc with AArch64Insn, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 08/29] tcg-aarch64: Introduce tcg_fmt_Rdn_aimm, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 09/29] tcg-aarch64: Implement mov with tcg_fmt_* functions, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 10/29] tcg-aarch64: Handle constant operands to add, sub, and compare, Richard Henderson, 2013/09/02