Re: [Qemu-devel] [PATCH v7 6/8] Makefile: install modules with "make install"

[Fam Zheng]

On Thu, 09/12 15:06, Daniel P. Berrange wrote:
> On Thu, Sep 12, 2013 at 03:04:57PM +0800, Fam Zheng wrote:
> > Install all the subdirs for modules under configure option "moddir".
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  Makefile | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index ef76967..00c2a52 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -360,6 +360,12 @@ install-datadir install-localstatedir
> >  ifneq ($(TOOLS),)
> >     $(INSTALL_PROG) $(STRIP_OPT) $(TOOLS) "$(DESTDIR)$(bindir)"
> >  endif
> > +ifneq ($(CONFIG_MODULES),)
> > +   for s in $(patsubst %.mo,%(DSOSUF),$(modules-m)); do \
> 
> Typo, causing install failure:
> 
> for s in block/iscsi(DSOSUF) block/curl(DSOSUF) block/rbd(DSOSUF) 
> block/gluster(DSOSUF) block/ssh(DSOSUF); do \
>       install -d -m 0755 "/home/berrange/usr/qemu-git-mod/lib/qemu/$(dirname 
> $s)"; \
>       libtool --quiet --mode=install install -c -m 0755  $s 
> "/home/berrange/usr/qemu-git-mod/lib/qemu/$(dirname $s)"; \
> done
> /bin/sh: -c: line 0: syntax error near unexpected token `('
> /bin/sh: -c: line 0: `for s in block/iscsi(DSOSUF) block/curl(DSOSUF) 
> block/rbd(DSOSUF) block/gluster(DSOSUF) block/ssh(DSOSUF); do \'
> make: *** [install] Error 1
> 
> 
> Just  s/%(DSOSUF)/%$(DSOSUF)/ I believe
> 
Yes, thanks for catching.

Fam