Re: [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp

[Luiz Capitulino]

On Wed, 11 Sep 2013 16:13:32 -0600
Eric Blake <address@hidden> wrote:

> On 09/11/2013 04:08 PM, Eric Blake wrote:
> > On 09/11/2013 02:52 PM, Luiz Capitulino wrote:
> >> Populate it with all scripts stored in QMP/.
> >>
> >> Signed-off-by: Luiz Capitulino <address@hidden>
> 
> > Reviewed-by: Eric Blake <address@hidden>
> > 
> > Repeat after me:
> > git config diff.renames true
> > 
> > at which point, this commit is much more compact and reviewable:

Done.

> Oh, and while testing your patch:
> 
> <stdin>:1854: trailing whitespace.
> 
> <stdin>:2054: trailing whitespace.
> #
> warning: 2 lines add whitespace errors.
> 
> One instance from qmp-shell; the other from qmp.py.  It's okay if you
> touch those up as part of this rename (again, the diff.renames true bit
> will highlight those two changes, rather than showing the complete file
> as a delete and addition).

Fixed.