[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/12] iscsi: add .bdrv_co_write_zeroes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/12] iscsi: add .bdrv_co_write_zeroes |
Date: |
Fri, 13 Sep 2013 12:10:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/13/2013 04:25 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block/iscsi.c | 78
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 78 insertions(+)
>
> + if (iscsilun->zeroblock == NULL) {
> + iscsilun->zeroblock = g_malloc(iscsilun->block_size);
> + if (iscsilun->zeroblock == NULL) {
> + return -ENOMEM;
g_malloc cannot return NULL (it aborts the program on OOM instead), so
this is dead code.
> + }
> + memset(iscsilun->zeroblock, 0x00, iscsilun->block_size);
Furthermore, if you had used g_malloc0(), you wouldn't need this memset.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/12] block: logical block provisioning enhancements, Peter Lieven, 2013/09/13
- [Qemu-devel] [PATCH 01/12] block: make BdrvRequestFlags public, Peter Lieven, 2013/09/13
- [Qemu-devel] [PATCH 03/12] block: introduce BDRV_REQ_MAY_UNMAP in bdrv_co_write_zeroes, Peter Lieven, 2013/09/13
- [Qemu-devel] [PATCH 04/12] iscsi: add .bdrv_co_write_zeroes, Peter Lieven, 2013/09/13
- Re: [Qemu-devel] [PATCH 04/12] iscsi: add .bdrv_co_write_zeroes,
Eric Blake <=
- [Qemu-devel] [PATCH 02/12] block: add flags to bdrv_*_write_zeroes, Peter Lieven, 2013/09/13
- [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert, Peter Lieven, 2013/09/13
- Re: [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert, Paolo Bonzini, 2013/09/13
- Re: [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert, Eric Blake, 2013/09/13
- Re: [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert, Peter Lieven, 2013/09/13
- Re: [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert, Eric Blake, 2013/09/13
- Re: [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert, Paolo Bonzini, 2013/09/16