[Qemu-devel] [PATCH] qom: helper macro for adding read-only properties

[Michael S. Tsirkin]

Add a helper macro for adding read-only properties, that works in the
common case where the value is a constant.

Signed-off-by: Michael S. Tsirkin <address@hidden>
---

I'm using this patch in my acpi work - any objections
to applying it on my tree?

 include/qom/object.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/include/qom/object.h b/include/qom/object.h
index 1a7b71a..4787de6 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -17,6 +17,7 @@
 #include <glib.h>
 #include <stdint.h>
 #include <stdbool.h>
+#include "qemu/typedefs.h"
 #include "qemu/queue.h"
 
 struct Visitor;
@@ -792,6 +793,26 @@ void object_property_add(Object *obj, const char *name, 
const char *type,
                          ObjectPropertyRelease *release,
                          void *opaque, struct Error **errp);
 
+/* Add a property that is an integer constant. */
+#define OBJECT_ADD_PROP_CONST(obj, name, value)                      \
+    do {                                                                    \
+        void OBJECT_ADD_PROP_GET(Object *OBJECT_ADD_PROP_OBJ,               \
+                                 struct Visitor *OBJECT_ADD_PROP_VISITOR,   \
+                                 void *OBJECT_ADD_PROP_OPAQUE,              \
+                                 const char *OBJECT_ADD_PROP_NAME,          \
+                                 struct Error **OBJECT_ADD_PROP_VALUE_ERR)  \
+        {                                                                   \
+            int64_t OBJECT_ADD_PROP_VALUE = value;                          \
+                                                                            \
+            visit_type_int64(OBJECT_ADD_PROP_VISITOR,                       \
+                             &OBJECT_ADD_PROP_VALUE,                        \
+                             OBJECT_ADD_PROP_NAME,                          \
+                             OBJECT_ADD_PROP_VALUE_ERR);                    \
+        }                                                                   \
+        object_property_add(obj, name, "int", OBJECT_ADD_PROP_GET,          \
+                            NULL, NULL, NULL, NULL);                        \
+    } while (0)
+
 void object_property_del(Object *obj, const char *name, struct Error **errp);
 
 /**
-- 
MST