Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort

[Marcel Apfelbaum]

On Sun, 2013-09-15 at 18:32 +0100, Peter Maydell wrote:
> On 15 September 2013 18:30, Michael S. Tsirkin <address@hidden> wrote:
> > On Sun, Sep 15, 2013 at 07:16:41PM +0300, Marcel Apfelbaum wrote:
> >> +static const MemoryRegionOps master_abort_mem_ops = {
> >> +    .read = master_abort_mem_read,
> >> +    .write = master_abort_mem_write,
> >> +    .endianness = DEVICE_NATIVE_ENDIAN,
> >> +};
> >> +
> >
> > Please make it little endian.
> > DEVICE_NATIVE_ENDIAN is almost always a bug.
> 
> ...when dealing with PCI devices. For a random device on the system bus
> it's often correct.
But this is a PCI bus, I'll change it to little endian.
Thanks!
Marcel

> 
> -- PMM