[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize |
Date: |
Tue, 17 Sep 2013 17:45:41 +0300 |
On Tue, Sep 17, 2013 at 04:41:45PM +0200, Paolo Bonzini wrote:
> Il 17/09/2013 14:47, Michael S. Tsirkin ha scritto:
> > Ergo, to make sure a referenced MR does not get
> > destroyed, we must make sure only finalize
> > calls memory_region_destroy.
> >
> > So I think this patchset should do exactly that,
> > not try to move out more stuff to finalize.
>
> Yes, this is the part of the problem that applies to all devices.
>
> Some devices may have timers or other dynamically-allocated data that
> may be used between exit and finalize. The same applies to capabilities
> such as MSI and MSI-X. All this must also be moved to finalize, but
> this can be done in separate patches.
>
> I'll separate the series as follows:
>
> - memory_region_destroy
>
> - unregister_savevm
What's the problem here exactly?
> - other dynamically allocated data
And here? I don't think we should move rundom stuff out to finalize
just because we can.
> - del_vm_change_state_handler
>
> - MSI-X
>
> - SHPC, AER and other PCI/bridge stuff
>
> Paolo
Let's document specific problems and fix them.
Randomly moving cleanup order has a high chance to
introduce bugs.
- [Qemu-devel] [PATCH 35/38] virtio-pci: reclaim memory in instance_finalize instead of exit, (continued)
- [Qemu-devel] [PATCH 35/38] virtio-pci: reclaim memory in instance_finalize instead of exit, Paolo Bonzini, 2013/09/03
- [Qemu-devel] [PATCH 36/38] wdt_i6300esb: use instance_finalize instead of exit, Paolo Bonzini, 2013/09/03
- [Qemu-devel] [PATCH 37/38] xen_pt: reclaim memory in instance_finalize instead of exit, Paolo Bonzini, 2013/09/03
- [Qemu-devel] [PATCH 38/38] tpm: move add/del_subregion to realize/unrealize, Paolo Bonzini, 2013/09/03
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Paolo Bonzini, 2013/09/16
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Wenchao Xia, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Paolo Bonzini, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Paolo Bonzini, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Paolo Bonzini, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Paolo Bonzini, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Paolo Bonzini, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Paolo Bonzini, 2013/09/17
- Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize, Michael S. Tsirkin, 2013/09/17