qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] [PATCHv10 00/31] aio / timers: Add AioContext tim


From: Alex Bligh
Subject: Re: [Qemu-devel] [RFC] [PATCHv10 00/31] aio / timers: Add AioContext timers and use ppoll
Date: Tue, 17 Sep 2013 18:03:34 +0100

On 17 Sep 2013, at 17:50, Jan Kiszka wrote:

>> 
>> If
>> that's true, I think we /shouldn't/ return. Equally if there
>> are no timers but something is genuinely attempting to wait
>> on an aio_notify, I don't think we should return.
>> 
> 
> In any case, test-aio seems to stress that if clause. If we remove it,
> the test case hangs infinitely. But I'm more worried about understanding
> if there are actual users depending on the current behavior
> (bdrv_drain_all?).

That's in make check, so I think that will be Stefan's
bdrv_drain* patches in combination with this, as the timer stuff
definitely passed make check. I think I'll defer to Stefan on
how bdrv_drain* is meant to work now as I think it had or was
proposed to have major surgery after the timer patches went in.

-- 
Alex Bligh







reply via email to

[Prev in Thread] Current Thread [Next in Thread]