qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 00/38] Delay destruction of memory regions to instance_finalize
Date: Wed, 18 Sep 2013 09:40:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

Il 18/09/2013 07:48, Michael S. Tsirkin ha scritto:
> So I think the fix is actually obeying ordering rules,
> that is know that write is in progress
> and flush on read.

I think this can be modeled as a generic, synchronous
(*busmaster_cancel)(PCIDevice*) callback, that is called after bus
master is turned off.  You don't even really have to wait for a read.

> I think moving memory region destroy out to finalize makes sense
> irrespectively, as long as destroy is made idempotent so we can simply
> destroy everything without worrying whether we initialized it.
> 
> The rest of the changes will be harder, we'll have to do
> them carefully on a case by case basis.

Good, we are in agreement then.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]