[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] osdep: warn if open(O_DIRECT) on fails with
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] osdep: warn if open(O_DIRECT) on fails with EINVAL |
Date: |
Wed, 18 Sep 2013 15:47:17 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Aug 22, 2013 at 11:29:01AM +0200, Stefan Hajnoczi wrote:
> After trying out a few approaches, here is what I think is the simplest viable
> way to print a user-friendly warning if opening a file O_DIRECT fails with
> EINVAL. This happens on Linux tmpfs.
>
> We don't really know why we got EINVAL but if O_DIRECT was used it's a good
> clue that the file system does not support O_DIRECT.
>
> Stefan Hajnoczi (2):
> libcacard: link against qemu-error.o for error_report()
> osdep: warn if open(O_DIRECT) on fails with EINVAL
>
> libcacard/Makefile | 3 ++-
> util/osdep.c | 7 +++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
Applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 0/2] osdep: warn if open(O_DIRECT) on fails with EINVAL,
Stefan Hajnoczi <=