Re: [Qemu-devel] [PATCHv2 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag

[Eric Blake]

On 09/17/2013 07:48 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  block-migration.c     |    3 ++-
>  block.c               |    4 ++++
>  block/backup.c        |    2 +-
>  include/block/block.h |    7 +++++++
>  4 files changed, 14 insertions(+), 2 deletions(-)


> +++ b/include/block/block.h
> @@ -65,6 +65,13 @@ typedef struct BlockDevOps {
>  typedef enum {
>      BDRV_REQ_COPY_ON_READ = 0x1,
>      BDRV_REQ_ZERO_WRITE   = 0x2,
> +    /* the BDRV_REQ_MAY_UNMAP flag is used to indicate that block driver

Minor grammar improvements:

s/the/The/
s/that/that the/

> +     * is allowed to optimize a write zeroes request by unmapping 
> (discarding)
> +     * blocks if it is guaranteed that the result will read back as
> +     * zeroes. the flag is only passed to the driver if the block device is

s/the flag/The flag/

> +     * opened with BDRV_O_UNMAP.
> +     */
> +    BDRV_REQ_MAY_UNMAP    = 0x4,

As those are trivial, feel free to add:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature