Re: [Qemu-devel] [PATCH 10/11] s390/ebcdic: Move conversion tables to header file

[Alexander Graf]

On 18.09.2013, at 05:19, Christian Borntraeger wrote:

> From: Heinz Graalfs <address@hidden>
> 
> Move conversion tables to header file.
>   - In SCLP line mode processing EBCDIC/ASCII conversion is needed.
>   - An additional EBCDIC to ASCII conversion function is added.
> 
> Signed-off-by: Heinz Graalfs <address@hidden>
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
> include/hw/s390x/ebcdic.h  | 107 +++++++++++++++++++++++++++++++++++++++++++++
> target-s390x/misc_helper.c |  81 +---------------------------------
> 2 files changed, 108 insertions(+), 80 deletions(-)
> create mode 100644 include/hw/s390x/ebcdic.h
> 
> diff --git a/include/hw/s390x/ebcdic.h b/include/hw/s390x/ebcdic.h
> new file mode 100644
> index 0000000..992f8c6
> --- /dev/null
> +++ b/include/hw/s390x/ebcdic.h
> @@ -0,0 +1,107 @@
> +/*
> + * EBCDIC/ASCII conversion Support
> + *
> + * Copyright (c) 2011 Alexander Graf
> + * Copyright IBM, Corp. 2013
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or (at 
> your
> + * option) any later version.  See the COPYING file in the top-level 
> directory.
> + *
> + */
> +
> +#ifndef EBCDIC_H_
> +#define EBCDIC_H_
> +
> +#ifndef CONFIG_USER_ONLY

No need for the #ifndef. You're already in hw/ :).


Alex