[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] block: use QEMU_PACKED for on-disk structur
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/5] block: use QEMU_PACKED for on-disk structures |
|
Date: |
Fri, 20 Sep 2013 10:07:42 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 19.09.2013 um 20:43 hat Jeff Cody geschrieben:
> Several block image formats did not consistently use packed attributes
> when directly reading / writing structures from disk (mainly image format
> headers).
>
> These series updates the image formats (see list below), to use
> QEMU_PACKED for on-disk structs. (Some minor code cleanup may also
> have ensued, to keep checkpatch.pl happy)
One comment on coding style: It seems to be more common to have the
QEMU_PACKED attribute after the fields, i.e.:
struct foo {
...
} QEMU_PACKED;
Kevin