[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/6] qcow2: Make overlap check mask variable
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH 2/6] qcow2: Make overlap check mask variable |
Date: |
Fri, 20 Sep 2013 10:37:07 +0200 |
Replace the QCOW2_OL_DEFAULT macro by a variable overlap_check in
BDRVQcowState.
Signed-off-by: Max Reitz <address@hidden>
---
block/qcow2-refcount.c | 2 +-
block/qcow2.c | 2 ++
block/qcow2.h | 5 ++---
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 2fa6acb..3edd558 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -1650,7 +1650,7 @@ int qcow2_check_metadata_overlap(BlockDriverState *bs,
int ign, int64_t offset,
int64_t size)
{
BDRVQcowState *s = bs->opaque;
- int chk = QCOW2_OL_DEFAULT & ~ign;
+ int chk = s->overlap_check & ~ign;
int i, j;
if (!size) {
diff --git a/block/qcow2.c b/block/qcow2.c
index 13c9d5e..a1b854c 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -631,6 +631,8 @@ static int qcow2_open(BlockDriverState *bs, QDict *options,
int flags,
s->discard_passthrough[QCOW2_DISCARD_OTHER] =
qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_OTHER, false);
+ s->overlap_check = QCOW2_OL_CACHED;
+
qemu_opts_del(opts);
if (s->use_lazy_refcounts && s->qcow_version < 3) {
diff --git a/block/qcow2.h b/block/qcow2.h
index b5a158f..7dd787d 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -203,6 +203,8 @@ typedef struct BDRVQcowState {
bool discard_passthrough[QCOW2_DISCARD_MAX];
+ int overlap_check; /* bitmask of Qcow2MetadataOverlap values */
+
uint64_t incompatible_features;
uint64_t compatible_features;
uint64_t autoclear_features;
@@ -321,9 +323,6 @@ typedef enum QCow2MetadataOverlap {
QCOW2_OL_REFCOUNT_TABLE | QCOW2_OL_REFCOUNT_BLOCK | \
QCOW2_OL_SNAPSHOT_TABLE | QCOW2_OL_INACTIVE_L1)
-/* The default checks to perform */
-#define QCOW2_OL_DEFAULT QCOW2_OL_CACHED
-
#define L1E_OFFSET_MASK 0x00ffffffffffff00ULL
#define L2E_OFFSET_MASK 0x00ffffffffffff00ULL
#define L2E_COMPRESSED_OFFSET_SIZE_MASK 0x3fffffffffffffffULL
--
1.8.3.1
- [Qemu-devel] [PATCH 0/6] Configure metadata overlap checks at runtime, Max Reitz, 2013/09/20
- [Qemu-devel] [PATCH 1/6] qcow2: Use negated overflow check mask, Max Reitz, 2013/09/20
- [Qemu-devel] [PATCH 2/6] qcow2: Make overlap check mask variable,
Max Reitz <=
- [Qemu-devel] [PATCH 3/6] qcow2: Add overlap-check options, Max Reitz, 2013/09/20
- [Qemu-devel] [PATCH 4/6] qcow2: Array assigning options to OL check bits, Max Reitz, 2013/09/20
- [Qemu-devel] [PATCH 5/6] qcow2: Add more overlap check bitmask macros, Max Reitz, 2013/09/20
- [Qemu-devel] [PATCH 6/6] qcow2: Evaluate overlap check options, Max Reitz, 2013/09/20