[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] block: don't lose data from last incomplete
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] block: don't lose data from last incomplete sector |
Date: |
Fri, 20 Sep 2013 16:41:28 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Sep 18, 2013 at 07:14:14PM +0800, Fam Zheng wrote:
> To read the last sector that is not aligned to sector boundary, current
> code for growable backends, since commit 893a8f6 "block: Produce zeros
> when protocols reading beyond end of file", drops the data and directly
> returns zeroes. That is incorrect.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I merged this patch because I hit the problem myself today. And my code
includes a test case which will be posted soon.
So don't worry about writing a test case for this patch. I still don't
fully understand the vmdk patch and would like a test case for it.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan