qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/17] blockdev: Introduce DriveInfo.enable_auto


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 03/17] blockdev: Introduce DriveInfo.enable_auto_del
Date: Fri, 20 Sep 2013 09:03:21 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/20/2013 05:54 AM, Kevin Wolf wrote:
> BlockDriverStates shouldn't be affected by an unplugged guest device,
> except if created with the legacy -drive command line option or the
> drive_add HMP command.
> 
> Make the automatic deletion as well as cancelling of jobs conditional on
> an enable_auto_del boolean that is only set in drive_init().
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---

> +++ b/include/sysemu/blockdev.h
> @@ -37,6 +37,7 @@ struct DriveInfo {
>      int bus;
>      int unit;
>      int auto_del;               /* see blockdev_mark_auto_del() */
> +    bool enable_auto_del; /* Only for legacy drive_init() */

auto_del is 0-initialized, and only ever assigned to 1.  Should it also
be bool?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]