[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/11] qemu-timer: drop outdated signal safety commen
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 03/11] qemu-timer: drop outdated signal safety comments |
Date: |
Fri, 20 Sep 2013 19:42:03 +0200 |
host_alarm_handler() is invoked from the signal processing thread
(currently the iothread). Previously we did processing in a real signal
handler with signalfd and therefore needed signal-safe timer code.
Today host_alarm_handler() just marks the alarm timer as expired/pending
and notifies the main loop using qemu_notify_event().
Therefore these outdated comments about signal safety can be dropped.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
qemu-timer.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index 95ff47f..ed3fcb2 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -301,8 +301,6 @@ void timer_del(QEMUTimer *ts)
{
QEMUTimer **pt, *t;
- /* NOTE: this code must be signal safe because
- timer_expired() can be called from a signal. */
pt = &ts->timer_list->active_timers;
for(;;) {
t = *pt;
@@ -325,8 +323,6 @@ void timer_mod_ns(QEMUTimer *ts, int64_t expire_time)
timer_del(ts);
/* add the timer in the sorted list */
- /* NOTE: this code must be signal safe because
- timer_expired() can be called from a signal. */
pt = &ts->timer_list->active_timers;
for(;;) {
t = *pt;
--
1.8.3.1
- [Qemu-devel] [PULL 00/11] Block patches, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 01/11] libcacard: link against qemu-error.o for error_report(), Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 02/11] osdep: warn if open(O_DIRECT) on fails with EINVAL, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 03/11] qemu-timer: drop outdated signal safety comments,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 04/11] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 05/11] qemu-timer: do not take the lock in timer_pending, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 06/11] coroutine: add qemu_coroutine_yield benchmark, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 07/11] coroutine: fix /perf/nesting coroutine benchmark, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 08/11] qcow2: Correct snapshots size for overlap check, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 09/11] block: don't lose data from last incomplete sector, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 10/11] blockdev: do not default cache.no-flush to true, Stefan Hajnoczi, 2013/09/20
- [Qemu-devel] [PULL 11/11] virtio-blk: do not relay a previous driver's WCE configuration to the current, Stefan Hajnoczi, 2013/09/20