Re: [Qemu-devel] [PATCH 1/2] tests: build the helper program in main build process

[Michael Tokarev]

22.09.2013 12:30, Wenchao Xia пишет:
> This is a quick way to update helper program when qemu main code
> is changed or built, instead of adding new Makefile under test/qemu-iotest.

Why?

[]
> +# Build the help program automatically
> +
> +all: $(QEMU_IOTESTS_HELPERS-y)

This appears to be somewhat awkward way (to do something which I
clearly don't see).

First, it is not clear why this iotest helper should be built
by default when we hasn't been asked to perform the tests.

Second, it apparently does not achieve the (unknown) goal
anyway.  At least the patch does not do what the commit
coment says.  Commit says that the helper gets updated when
qemu main code is changed or built (which is main code?).
But when I build, say, subdir-x86_64-softmmu, which is
definitely some "main" code, the helper isn't being built...

Count me confused...  :)

/mjt