[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' |
|
Date: |
Mon, 23 Sep 2013 07:57:54 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/22/2013 12:50 AM, Mark Wu wrote:
> Now we have several qemu-ga commands not returning response on success.
> It has been documented in qga/qapi-schema.json already. This patch exposes
> the 'success-response' flag by extending 'guest-info' command. With this
> change, the clients can handle the command response more flexibly.
>
> Changes:
> v2: add the notation 'since 1.7' to the option 'success-response'
> (per Eric Blake's comments)
Typically, the patch changelog should be placed...
>
> Signed-off-by: Mark Wu <address@hidden>
> ---
...after the --- separator (see
http://wiki.qemu.org/Contribute/SubmitAPatch for more hints).
> +++ b/qga/qapi-schema.json
> @@ -141,10 +141,13 @@
> #
> # @enabled: whether command is currently enabled by guest admin
> #
> +# @success-response: whether command returns a response on success
> +# and only available since 1.7
More typically, this is written:
@success-response: whether command returns a response on
success (since 1.7)
but as we don't parse the documentation, it doesn't hurt as written.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature