|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command |
Date: | Tue, 24 Sep 2013 12:39:05 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 20/09/2013 13:54, Kevin Wolf ha scritto: > + * For now, simply forbidding the combination for all drivers will do. */ > + if (options->has_aio && options->aio == BLOCKDEV_A_I_O_OPTIONS_NATIVE) { Let's call it BlockdevAioOptions instead? Paolo > + bool direct = options->cache->has_direct && options->cache->direct; > + if (!options->has_cache && !direct) { > + error_setg(errp, "aio=native requires cache.direct=true");
[Prev in Thread] | Current Thread | [Next in Thread] |