[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv3 16/20] block/get_block_status: avoid redundant cal
From: |
Peter Lieven |
Subject: |
[Qemu-devel] [PATCHv3 16/20] block/get_block_status: avoid redundant callouts on raw devices |
Date: |
Tue, 24 Sep 2013 15:35:10 +0200 |
if a raw device like an iscsi target or host device is used
the current implementation makes a second call out to get
the block status of bs->file. however, the raw driver already
has called bdrv_get_block_status on bs->file.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Peter Lieven <address@hidden>
---
block.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 3bf1163..f56660d 100644
--- a/block.c
+++ b/block.c
@@ -3277,7 +3277,8 @@ static int64_t coroutine_fn
bdrv_co_get_block_status(BlockDriverState *bs,
if (bs->file &&
(ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO) &&
- (ret & BDRV_BLOCK_OFFSET_VALID)) {
+ (ret & BDRV_BLOCK_OFFSET_VALID) &&
+ strcmp(bs->drv->format_name, "raw")) {
ret2 = bdrv_co_get_block_status(bs->file, ret >> BDRV_SECTOR_BITS,
*pnum, pnum);
if (ret2 >= 0) {
--
1.7.9.5
- [Qemu-devel] [PATCHv3 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, (continued)
- [Qemu-devel] [PATCHv3 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 07/20] block: honour BlockLimits in bdrv_co_do_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 08/20] block: honour BlockLimits in bdrv_co_discard, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 12/20] iscsi: add bdrv_co_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 10/20] iscsi: set limits in BlockDriverState, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 14/20] block/get_block_status: set *pnum = 0 on error, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 09/20] iscsi: simplify iscsi_co_discard, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 16/20] block/get_block_status: avoid redundant callouts on raw devices,
Peter Lieven <=
- [Qemu-devel] [PATCHv3 18/20] qemu-img: add support for fully allocated images, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 15/20] block/get_block_status: avoid segfault if there is no backing_hd, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 19/20] qemu-img: conditionally zero out target on convert, Peter Lieven, 2013/09/24