Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage

[Jeff Cody]

On Mon, Sep 23, 2013 at 02:45:13PM +0200, Stefan Hajnoczi wrote:
> On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote:
> > diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043
> > index 478773d..ae7cf27 100755
> > --- a/tests/qemu-iotests/043
> > +++ b/tests/qemu-iotests/043
> > @@ -31,7 +31,7 @@ status=1  # failure is the default!
> >  _cleanup()
> >  {
> >      _cleanup_test_img
> > -    rm -f $TEST_IMG.[123].base
> > +    rm -f "$TEST_IMG.[123].base"
> 
> This changes the semantics:
> 
>   $ touch a1 a2 a3
>   $ echo a[123]
>   a1 a2 a3
>   $ echo "a[123]"
>   a[123]

Yes, that should be "$TEST_IMG".[123].base instead.